Adaptive Replacement Cache (ARC) by devxadarsh · Pull Request #5116 · TheAlgorithms/Java

devxadarsh · 2024-04-23T05:44:34Z

I have read CONTRIBUTING.md.
This pull request is all my own work -- I have not plagiarized it.
All filenames are in PascalCase.
All functions and variable names follow Java naming conventions.
All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
All new code is formatted with clang-format -i --style=file path/to/your/file.java

sozelfist · 2024-04-23T15:11:48Z

Have you read the CONTRIBUTING.md correctly? It would help if you wrote parametrized tests in a separate file in the test directory. You can refer to current implementations in this repository to know how to write tests.

codecov-commenter · 2024-04-23T19:35:03Z

Codecov Report

Attention: Patch coverage is 62.00000% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 38.65%. Comparing base (1607421) to head (5b68052).

Files	Patch %	Lines
.../thealgorithms/datastructures/caches/ARCCache.java	62.00%	16 Missing and 3 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #5116      +/-   ##
============================================
+ Coverage     38.56%   38.65%   +0.08%     
- Complexity     2378     2388      +10     
============================================
  Files           516      517       +1     
  Lines         15313    15363      +50     
  Branches       2957     2963       +6     
============================================
+ Hits           5906     5938      +32     
- Misses         9121     9137      +16     
- Partials        286      288       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sozelfist · 2024-04-24T02:55:24Z

Please ensure that tests are added to handle lines with partial coverage.

devxadarsh

I reviewed and update the code

sozelfist · 2024-04-24T13:34:09Z

You should format the code. LGTM

….java

It aims to provide better performance compared to traditional caching algorithms like LRU (Least Recently Used) and LFU (Least Frequently Used).

Main Method Removed for ARCCache.java

Test cases added for the ARC

….java Co-authored-by: SOZEL <80200848+TruongNhanNguyen@users.noreply.github.com>

Replaced private final p(Pivot) using private final int t1Capacity; private final int b1Capacity; adjustCacheSize();

updated test case for t1capacity and b1 capacity

devxadarsh

Updated comments

sozelfist · 2024-05-02T01:01:26Z

Please format your code using clang-format.

Updated capacity method

Updated capacity method to handle negative input

vil02 · 2024-05-09T18:12:43Z

Please add the missing tests and update your branch.

github-actions · 2024-06-25T00:21:13Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution!

github-actions · 2024-07-02T00:21:39Z

Please reopen this pull request once you have made the required changes. If you need help, feel free to ask in our Discord server or ping one of the maintainers here. Thank you for your contribution!

devxadarsh requested review from BamaCharanChhandogi, vil02 and yanglbme as code owners April 23, 2024 05:44